Skip to content

[Port to dspace-8_x] Fix submission form's "serious" accessibility issues#5298

Open
AndreaBarbasso wants to merge 1 commit intoDSpace:dspace-8_xfrom
4Science:task/dspace-8_x/CST-24622
Open

[Port to dspace-8_x] Fix submission form's "serious" accessibility issues#5298
AndreaBarbasso wants to merge 1 commit intoDSpace:dspace-8_xfrom
4Science:task/dspace-8_x/CST-24622

Conversation

@AndreaBarbasso
Copy link
Contributor

@AndreaBarbasso AndreaBarbasso commented Mar 19, 2026

References

Description

Added a11y features for "serious" problems occurring in the submission form.

Instructions for Reviewers

List of changes in this PR:

  • Added necessary aria attributes in order to pass axe accessibility tests;
  • Implemented live region messages for the upload progressbar and for submission error messages.

To test/review the PR, check that the functionality of the submission form has not been altered, and that a11y tests now do not contain serious issues.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace Maintenance (9.x, 8.x, 7.6.x) Mar 19, 2026
@lgeggleston lgeggleston added this to the 8.4 milestone Mar 19, 2026
@lgeggleston lgeggleston changed the title backporting of #1187 to 8.x [Port to dspace-8_x] Fix submission form's "serious" accessibility issues Mar 19, 2026
@lgeggleston
Copy link

@AndreaBarbasso thank you for porting this! Just to note it looks like this is failing a couple of unit tests (something to do with 'NgbModal').

@AndreaBarbasso AndreaBarbasso force-pushed the task/dspace-8_x/CST-24622 branch from 2411590 to df3fb98 Compare March 19, 2026 15:31
@AndreaBarbasso
Copy link
Contributor Author

AndreaBarbasso commented Mar 19, 2026

@AndreaBarbasso thank you for porting this! Just to note it looks like this is failing a couple of unit tests (something to do with 'NgbModal').

Thanks @lgeggleston for the heads-up! I managed to fix the failing test, everything should be good now.

EDIT: nevermind, working on the failing e2e test now.

@tdonohue tdonohue moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👍 Reviewer Approved

Development

Successfully merging this pull request may close these issues.

3 participants